I agree, it does not look too bad overall, but the fuller story of how long have you had it?, does it clunk when slowly turning when it rains?. When were the knuckles rebuilt last? You won't know the extent of the condition until you look at the springs and perches disassembled. A bit goes on with all the components of the front.
If the front leaves of a 30+ lc is left unchecked due to it's design the holes of the saddle perches slop out as in the nasty picture, from a paddock basher. I have restored the holes and balls on another axle housing, not as well as some on here, it is difficult to find a used one in good condition.
30+ years, one has to go over the whole vehicle really, in time. Not saying yours shall look like this, but they end up this way if neglected. Your plastic grommet does not look 30+. And from your pics, yours looks pretty neat. How are your spring bushes?
Also depends on your temperament, some spend all their money and time loving their cruisers others drive them into the ground. Sometimes you see cheap used springs in pretty good nick on fb marketplace as folks fashionably get springs with lift.
I do like the design of the anti inversion greaseable shackles personally, dobinsons have a hollow nut to protect the grease nipple which was a selling point to me.
Grand scheme, personally I like to have my cruiser in the best condition I can afford, for peace of mind when remote. You may get another 100k kms from those springs without worries, but if you hear a front clunk when it rains, I would get greaseable shackles and fresh springs and you can forget about it for quite a few years. If you knew how old the springs were it would help. If not old, just bend the clamp back, maybe ok if you re weld it. Bit of an irony when things are the same price to fix as to buy new..too full of opinion i am!