The pinion angle should be the same we there the suspension is loaded or unloaded right?
Not exactly, but close enough not to fret over. The rear shackle allows the end of the spring to lift upwards a wee bit when the spring compresses, essentially rotating the entire spring upwards a tad from the back... maybe changing the pinion angle minus a degree or two.
But that is all academic.
What really hoses all the careful pinion angle calculations and fitments is just a good ole bumpy dirt road. If you want to see how (un important) pinion angles are...just take a look at the rear wheel when driving off road. The axle is all over the place.. vibration is insane.. and any semblance of a "correct" driveline angle is sheer fantasy.... regardless of the resting angle.
As a wise LC shaman once told me... "I'd rather replace a U-Joint every few decades... than a pinion gear due to lack of lubrication, due to a tilted up differential".
Well, maybe he didn't say it in so many words... but you get the point. U-Joints are cheap. Pinion gears are not. Aim for 0º