Search is generating bad URLs

[yooper]

The search function is intermittently generating bad URLs.

For example, this search: IH8MUD.com Forum - Search Results , searching for posts by semlin containing "fucked", generates this URL as its first result: http://forum.ih8mud.com/chit-chat-se...ml#post2915988

which generates a 400 "Bad Request" error

The problem is repeatable, i.e. that particular search always generates bad URLs. Furthermore all of the results for that particular search are bad. But not all searches are doing this, only a small minority.

I haven't investigated rigorously but so far I don't see a pattern. It's not just semlin, we recently saw a similar failure in TUT when searching for an old grrlscout89FJ62 post.

[woody]

I'll wager that the "%" sign in the url is the problem....results from the SEO plugin....not sure that's a fixable issue however, but i'll look into it....

nice search term

[yooper]

Originally Posted by woody

nice search term

I thought you'd appreciate that. But it was a real search I did.

[yooper]

Still happening. Pretty big PITA, makes search worthless for most users.

A useful search function I would think is more important that automatic parsing of URLs....I vote for dumping the SEO plugin if it's the culprit...

[woody]

give me some specific search term examples...non-curse ones please....

[yooper]

All posts by DSRTRDR containing the word "secret"

IH8MUD.com Forum - Search Results

[yooper]

Originally Posted by yooper

All posts by DSRTRDR containing the word "secret"

IH8MUD.com Forum - Search Results

If you manually edit out the % then it works...

[woody]

so, the bug only applies to threads with a % in them?

"believe" I have it fixed....but it may take a day to populate things....

[yooper]

could be. I just checked that search I posted and some of the links work...

[gladly]

the one strange thing that I have found with search is that if I do an advanced search in 'title only' for "ultimate", I get:

Fatal error: Allowed memory size of 67108864 bytes exhausted (tried to allocate 71 bytes) in /home/forum/search.php on line 1123

(BTW I get the same result with 'thread' and '35%')

[woody]

likely because there are 300,000+ posts with that in the title.....guaranteed crash....

[gladly]

that could be an issue...

[gladly]

though I was looking for threads, not posts

[yzftaco]

I'm searching for "60 series rear springs" in the 40 section
and I get this:

Fatal error: Allowed memory size of 67108864 bytes exhausted (tried to allocate 71 bytes) in /home/forum/search.php on line 1033

[woody]

sounds like it's time for some memory adjustments again.....thanks!

[yooper]

Still getting some bad URLs.

IH8MUD.com Forum - Search Results is a search for "Linda Carter" in TUT #26. Only one result, bad URL.

[woody]

they it's still a % issue....i'll try and find a solution, but if it's just that thread....well....lol

[hks3sgte]

Originally Posted by yzftaco

Fatal error: Allowed memory size of 67108864 bytes exhausted (tried to allocate 71 bytes) in /home/forum/search.php on line 1033

when I search for "part time" in the 100 tech, i get:

Fatal error: Allowed memory size of 67108864 bytes exhausted (tried to allocate 82 bytes) in /home/forum/includes/functions.php on line 51

[woody]

yep, discovered that issue this week as well...thus far, the solution's that should work aren't....

[NaterGator]

The original issue with the broken search link is because of the percent (%) sign. It is not being properly URL escaped and se the vbSEO rewrite rule breaks the link back to the correct path.

The percent sign's urlcode is %25, so simply adding the number 25 behind the offending % sign works. This seems to be (yet another) vbSEO bug.



The memory allocation on the search function... I dunno. Either vbSEO applied a modification that runs on large objects in memory (such as some sort of complicated url translation on all search results) or they are not freeing memory as they are done with stuff. 64mb of memory is way more than enough to perform a search